Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter issues #1064

Closed
DonJayamanne opened this issue Mar 13, 2018 · 4 comments · Fixed by #1903
Closed

Linter issues #1064

DonJayamanne opened this issue Mar 13, 2018 · 4 comments · Fixed by #1903
Assignees
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@DonJayamanne
Copy link

  • When checking whether a linter exists, we're always treating linters as modules in the current python installation. I.e. if user has provided fully qualified path to linter, we still check if linter is installed using pythong -c 'import <linter>'
  • The telemetry captured to determine whether a user has provided a fully qualified path to a linter no longer works (logic is incorrect)
  • Assume user enters the path to a linter in settings.json, and the path is invalid.
    We'll display the message Linter xxx is not installed [Install] [Disable xxx] [Disable linting]
    If user opts to install, they'll keep getting the above error as the path provided in settings.json is invalid.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-linting needs PR labels Mar 13, 2018
@brettcannon brettcannon added this to the June 2018 milestone Jun 5, 2018
@DonJayamanne
Copy link
Author

Sample messages that will be displayed for Test Frameworks, Linters and Formatters (when the paths are invalid):

screen shot 2018-06-07 at 12 49 47 pm

@brettcannon
Copy link
Member

The prompt is not triggered if you specify "doesnotexist"; it seems to be specific to lacking a path separator.

@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 18, 2018

@brettcannon
Do you not get any prompt when you use doesnotexist?
There are two types of prompts, one that will mention the invalid path and the other thats a generic message.
Works for me on both Mac and Windows.

@brettcannon
Copy link
Member

I get the generic message to install Black.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants