-
-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time for a monorepo #1875
Comments
I'm for it, but I'd rather wait for #1592 to be merged in if you don't mind (unless git is smart enough to track moving files when rebasing). |
I'm not in a huge rush, happy to manually merge stuff as it comes in. |
I'm for it, since we're already half-way there now. Just a few nits on that repo:
|
Both |
External dependencies will break the I thought that |
It ships stream currently, at least. https://unpkg.com/[email protected]/stream/stream I'd be totally fine with ceasing that practice though, I don't think that is a necessary part of mithril core to ship with a npm install. |
@tivac To clarify, I'm referring to this file pointing to a directory that doesn't exist. If we decide to unship it (I'm neutral on it, since I almost never use it personally), then my nit is moot. |
We keep on running into issues with things not being published and the repo root is starting to get messy. I think it's time for a monorepo.
@pygy, @isiahmeadows, @lhorie, anyone feel strongly for or against this plan?
Work has already started here: https://github.com/tivac/mithril.js/tree/monorepo
The text was updated successfully, but these errors were encountered: