From deab7fd75db3ac1e4827a83c0fd63144d1fffa4c Mon Sep 17 00:00:00 2001 From: Clay-Mysten <100217682+Clay-Mysten@users.noreply.github.com> Date: Tue, 22 Mar 2022 08:16:01 -0700 Subject: [PATCH] Update README.md Move TODOs to PR 732 for tracking: https://github.com/MystenLabs/sui/issues/732 --- explorer/README.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/explorer/README.md b/explorer/README.md index a997df4b51f34..6b972764fc2ec 100644 --- a/explorer/README.md +++ b/explorer/README.md @@ -4,15 +4,10 @@ Sui Explorer is a chain explorer for the Sui network, similiar in functionality ## Data source / RPC URL The Sui Explorer front end can use any Sui RPC URL as a backend, but it must have Cross-Origin Resource Sharing (CORS) set up. -TODO: Link to guidance for how we want this done. Something generic resembling: -https://docs.aws.amazon.com/AmazonS3/latest/userguide/enabling-cors-examples.html - To change the RPC URL, pass a [url-encoded](https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding) URL to the RPC parameter. So to use http://127.0.0.1:5000, the Sui REST API's default local port, use the URL: http://127.0.0.1:3000?rpc=http%3A%2F%2F127.0.0.1%3A5000%2F -TODO: Find out if we need the "%2F" URL at the end. Also, can we include the URL without character substitution? - This defaults to https://demo-rpc.sui.io (for now). The RPC URL preference will be remembered for three hours before being discarded - this way, it's not necessary to continually pass it on every page. @@ -57,8 +52,6 @@ Chrome doesn't let you make requests without CORS on the local host, but **Firef ## no more about running locally ## ---------------------------------------------------------------------- -TODO: Remove or populate the header above. - ## Proposed basic architecture This is described in order of how data flows, from the source network to the end user. Browser front end is a standard React app, powered by the HTTP API: