[wallet-ext] New wallet versioning strategy #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💳 Wallet Extension has been built, you can download the packaged extension here: https://github.com/MystenLabs/sui/actions/runs/3424442057#artifacts |
Jordan-Mysten
changed the title
Jordan-Mysten
changed the title
Jordan-Mysten
force-pushed
the
jordan--wallet-beta-builds
branch
from
529d317 to
70270e1
Compare
| } | ||
|
|
||
| const WALLET_BETA = !!process.env.WALLET_BETA; | ||
| const PATCH_VERISON = Number(process.env.PATCH_VERSION) || 0; |
There was a problem hiding this comment.
Is this used in case we need to publish again the same day?
There was a problem hiding this comment.
Yeah exactly, just buys us the ability to do multiple releases in a day in the event something goes wrong. Or if we do want a true patch release of a dated version, we can just cherry-pick commits onto it and issue a patch vs having to issue a full version.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jordan-Mysten
force-pushed
the
jordan--wallet-beta-builds
branch
from
e223e71 to
0ac5b22
Compare
sblackshear
approved these changes
Nov 9, 2022
Jibz1
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the wallet versioning strategy so that it is aligned with the new wallet release proposal. This includes support for beta builds, and better name labelling for the dev builds.
I removed the wallet version workflow as we're now accomplishing this through a different means (date-based versioning + beta builds).