Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove real land/sea/ice mask, use integer variable instead #704

Closed
climbfuji opened this issue Jul 22, 2021 · 2 comments · Fixed by #730, NOAA-EMC/fv3atm#388 or ufs-community/ufs-weather-model#804

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Jul 22, 2021

Description

The ccpp-physics code uses both real and integer land/sea/ice masks, mostly due to legacy code from different modeling systems (WRF, GFS).

There is no need for a type real land/sea/ice mask, which by definition takes integer values 0, 1, 2, ...

Your mission, should you choose to accept it, is to rewrite the physics schemes to use the integer land/sea/ice mask and terminate the real land/sea/ice mask. This issue will never self-destruct. It will stay up until someone completes the task.

@climbfuji
Copy link
Collaborator Author

Same for soil_type_classification_real/soil_type_classification and vegetation_type_classification_real/vegetation_type_classification

@ligiabernardet
Copy link
Collaborator

After this work is done, make sure the dictionary of standard names (https://github.com/ESCOMP/CCPPStandardNames) is updated accordingly (that is, remove standard names that end in _real).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment