You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When cf.Field.collapse operates along one or more axes spanned by a vertical coordinate reference system (such as standard_name:atmosphere_hybrid_height_coordinate), the code currently deletes any domain ancillaries that span the any of the collapse axes, but leaves other domain ancillaries behind, as well as the vertical coordinate reference system.
However, the CF conventions say that missing terms should be assumed to be zero, and so if the non-parametric vertical coordinates are computed they will likely give inappropriate, but possibly plausible, results - the worst kind of error!
So, removing the CRS and its contained constructs is certainly the safe thing to do by default, but you might want to keep it, perhaps to reinstate a new correct domain ancillary. Therefore, it should be possible to override the removal of the vertical CRS with a keyword parameter to cf.Field.collapse.
When
cf.Field.collapse
operates along one or more axes spanned by a vertical coordinate reference system (such asstandard_name:atmosphere_hybrid_height_coordinate
), the code currently deletes any domain ancillaries that span the any of the collapse axes, but leaves other domain ancillaries behind, as well as the vertical coordinate reference system.However, the CF conventions say that missing terms should be assumed to be zero, and so if the non-parametric vertical coordinates are computed they will likely give inappropriate, but possibly plausible, results - the worst kind of error!
So, removing the CRS and its contained constructs is certainly the safe thing to do by default, but you might want to keep it, perhaps to reinstate a new correct domain ancillary. Therefore, it should be possible to override the removal of the vertical CRS with a keyword parameter to
cf.Field.collapse
.PR to follow.
The text was updated successfully, but these errors were encountered: