Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent search bar #77

Closed
tbkkr opened this issue Feb 27, 2017 · 8 comments
Closed

Permanent search bar #77

tbkkr opened this issue Feb 27, 2017 · 8 comments
Assignees

Comments

@tbkkr
Copy link
Contributor

tbkkr commented Feb 27, 2017

I only found out today that there is a search option. How about making it better (=permanent) visible? That really helps people getting to their goal quicker. Here's an example of how did they that: https://componently.github.io/componently/.

@nielsdrost nielsdrost self-assigned this Feb 27, 2017
@nielsdrost
Copy link
Member

I think this is due to us using the "old" GitBook version 2.* instead of the "new" Gitbook, which had a problem with chapter numbering at the time. Will try updating, and see if anything breaks/improves.

@bouweandela
Copy link
Member

bouweandela commented Jun 28, 2018

Even with the new version, the search box will probably still not be permanently visible on our page, because our table of contents is too large to fit in the side bar. The example has a much shorter table of contents.

@bouweandela
Copy link
Member

Reaction from @tbkkr by email:

Misschien even kijken naar V2 van Gitbook, want draaien wij niet nog steeds de oude versie? Volgens mij is de search function wat aangepast in nieuwe versie van gitbook.

wb de ToC links: die moet misschien wat korter, bv:

2.1 > onderbrengen bij 2.7
2.8 en 2.9 ook ondebrengen bij 2.7 wellicht Bij IP & Licences zou ik vooral Licences neerzetten.
2.3 en 2.4 samen
2.6 en 2.7 samen
3.1 > kan weg?

@bouweandela
Copy link
Member

The search bar is indeed part of newer versions, but the problem is that chapter numbering is ugly in newer versions of gitbook, see e.g. GitbookIO/gitbook#1301. If we want the search bar, we should disable numbering the chapters in the table of contents or wait for gitbook to fix the issue.

@bouweandela
Copy link
Member

I discussed with @lodekulik and he advised that it is fine to drop the chapter numbers as is the default in newer gitbook versions. Therefore I think we can safely upgrade to the latest version.

@bouweandela
Copy link
Member

I have switched to the version 3 builder, which should solve this issue.

@bouweandela
Copy link
Member

Except that the search bar still disappears if you scroll down too far. So we need to reduce the number of chapters.

@egpbos
Copy link
Member

egpbos commented Oct 20, 2023

This discussion is outdated. We no longer use GitBook, but docsify. I have briefly looked into how to fix this issue, but cannot find a default option, even though here it is suggested that placing the search bar elsewhere is possible, but not without significant effort and the maintainability issues that brings.

If someone wants to open a PR to make the search bar permanently visible (and retains all other functionality), most welcome! This issue, in the meantime, can be closed.

@egpbos egpbos closed this as completed Oct 20, 2023
@egpbos egpbos closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants