Update PySAM to v6.0.0 #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging NREL/develop into local branch pre-pull-request
brookeslawski
commented
Feb 19, 2025
| @@ -22,6 +22,7 @@ else | |||
| echo "Conda installation not found. Please ensure Conda is installed and in your PATH." | |||
| exit 1 | |||
| fi | |||
| echo "$CONDA_PATH" | |||
There was a problem hiding this comment.
Not sure if I'm the only one, but HOPP has trouble finding my conda env so I thought this would be nice to add in case others have that issue too. Just helps with debugging
brookeslawski
commented
Feb 19, 2025
| @@ -42,7 +42,7 @@ py_sims: | |||
|
|
|||
| py_sim_type: SolarPySAM | |||
| verbose: True # flag to print debugging statements | |||
| weather_file_name: inputs/Flatirons_solar_data_highDNI.csv | |||
| weather_file_name: inputs/Flatirons_solar_data_sunset.csv # inputs/Flatirons_solar_data_highDNI.csv # | |||
There was a problem hiding this comment.
I chopped the solar input file to include the sunset timeframe, which includes variations in irradiance large enough to result in noticeable variations in solar farm output. Previously, the highDNI input data just showed a constant solar farm power output because the irradiance was so high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hercules had previously used PySAM v4.2.0, so this PR upgrades the PySAM version to the latest, which is v6.0.0.
This upgrade involved the following changes:
inputs/Flatirons_solar_data_highDNI.csvcalledinputs/Flatirons_solar_data_sunset.csv, which shows more dynamic fluctuations in the solar farm power output - this is better for testing the solar module