Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdminControlled: ownership transfer improvements #742

Merged
merged 5 commits into from
May 26, 2022
Merged

AdminControlled: ownership transfer improvements #742

merged 5 commits into from
May 26, 2022

Conversation

sept-en
Copy link
Contributor

@sept-en sept-en commented May 12, 2022

  • allow only nominated admin to accept the ownership over the contract;
  • this guarantees the nominated admin has control over his private key by the time of changing ownership of the contract.

Fixes #741

@sept-en
AdminControlled: ownership transfer improvements
62c4d2d 
* allow only nominated admin to accept the ownership over the contract
@sept-en sept-en requested review from karim-en and mfornet May 12, 2022 02:12
@sept-en sept-en marked this pull request as draft May 16, 2022 12:54
@sept-en sept-en marked this pull request as ready for review May 25, 2022 22:13
@sept-en sept-en merged commit b759c1b into master May 26, 2022
@sept-en sept-en deleted the admin-controlled-improvements-upd branch May 26, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karim-en karim-en karim-en approved these changes

@mfornet mfornet mfornet approved these changes

Assignees

@sept-en sept-en

@karim-en karim-en

@mfornet mfornet

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ownership of the contract: safe transfer of privileges
3 participants
@sept-en @karim-en @mfornet