Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with new release cant able to build core image symlinks error #2706

Closed
csetarun2 opened this issue Nov 16, 2022 · 5 comments
Closed

Issue with new release cant able to build core image symlinks error #2706

csetarun2 opened this issue Nov 16, 2022 · 5 comments

Comments

@csetarun2
Copy link

Im trying to build new release disptach application, when I execute the ./install.sh Im getting below error, I have tried 2 different server where I build dispatch app successfully with prev version..

(Vm1)
image

VM2:
Creating volumes for persistent storage...
Created dispatch-postgres.

Generating SECRET_KEY...
SECRET_KEY written to ./.env
Generating DISPATCH_JWT_SECRET...
DISPATCH_JWT_SECRET written to ./.env

Pulling, building, and tagging Docker images...

Pulling postgres ... done
postgres uses an image, skipping
web uses an image, skipping
scheduler uses an image, skipping
Building core
ERROR: Cannot locate specified Dockerfile: Dockerfile
Cleaning up...

can you please check once

@csetarun2
Copy link
Author

I have downloaded the release source code, there Dockerfile was missing (no docker folder)
image

can you please check once @mvilanova @kevgliss

@kevgliss
Copy link
Contributor

This was fixed in #2697. Depending on your use case for docker you can either use the new Dockerfile that was included in that release (now under .devcontainer) or pull the latest version from master that includes the fix from #2697. We will likely deprecate the docker folder at some point in favor .devcontainer but reverted the change because we had not yet update the documentation.

@csetarun2
Copy link
Author

Thanks @kevgliss , but how should I build the image now, can you share the steps,
currently as per documentation Im following these steps
step1: git clone https://github.com/Netflix/dispatch-docker.git
step2: ./install.sh
Then getting above issue, Please correct me If Im wrong, How to properly clone/run the code ?

@kevgliss
Copy link
Contributor

Yes, by default install.sh points to the latest released revision. Until we release a new version with #2697 you will have to change this line:

https://github.com/Netflix/dispatch-docker/blob/master/docker-compose.yml#L22
to
context: https://github.com/Netflix/dispatch.git#master

@csetarun2
Copy link
Author

Thanks @kevgliss for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants