-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this a drop in replacement for active_model_serializers? #115
Comments
#54 Adds a way to define custom attributes via a block, but there's been no gem release since this PR got merged. |
It is not a drop in replacement for AMS. However it is very similar to AMS so it should be easy to migrate. However note that fast_jsonapi only serializes to json:api spec |
@citizen428 any plans of doing it via a method. Block is nice, but a method has its advantages - mixins, inheritance to extend behavior. |
@kapso I don't know, I'm not a developer on this project, I just recently had the same question. There were alternative PRs but to the best of my knowledge none of them got merged yet. |
@citizen428 thanks for the clarification. @shishirmk any chances of merging changes that use a method instead of attribute block? |
@kapso we will resume the discussion about custom methods and what's the best for implementing it after of 1.1.0 release 😊 |
@guilleiguaran got it, thanks. Whats the timeline for |
@kapso |
Coz the serializer (see below) is not working and I get this error -
NoMethodError (undefined method
order_date' for #Order:0x00007fb6b78c4748)`active_model_serializers does allow you to attach attributes to local methods, looks like this gem does not allow this?
The text was updated successfully, but these errors were encountered: