Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make at least one <spikeThresh> required in <membraneProperties> #220

Closed
pgleeson opened this issue Apr 11, 2024 · 0 comments · Fixed by #222
Closed

Make at least one <spikeThresh> required in <membraneProperties> #220

pgleeson opened this issue Apr 11, 2024 · 0 comments · Fixed by #222
Labels
T: enhancement Type: enhancement

Comments

@pgleeson
Copy link
Member

Currently the default if this is missing is assumed to be 0mV, this should be made more explicit, and an error thrown if this element is missing.
e.g. missing from https://github.com/sanjayankur31/Human-L2-3-Cortical-Microcircuit/blob/9fccbdad4302aca3a92ba45f2e1df79c064f2f6f/NeuroML2/HL23PV.pas.cell.nml#L23003
@pgleeson pgleeson added the T: enhancement Type: enhancement label Apr 11, 2024
@sanjayankur31 sanjayankur31 moved this from 🆕 New to 🏗 In progress in NeuroML backlog Apr 17, 2024
@sanjayankur31 sanjayankur31 mentioned this issue Apr 17, 2024
Merged
@sanjayankur31 sanjayankur31 linked a pull request Apr 17, 2024 that will close this issue
feat: make spikeThresh required in membraneProperties #222
Merged
@sanjayankur31 sanjayankur31 moved this from 🏗 In progress to 👀 In review in NeuroML backlog Apr 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in NeuroML backlog Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement Type: enhancement
Projects
NeuroML backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make spikeThresh required in membraneProperties NeuroML/NeuroML2
1 participant
@pgleeson