From 6c831498d711f7cda9ef42eaf83a18f45eb2359a Mon Sep 17 00:00:00 2001 From: Padraig Gleeson Date: Fri, 25 Feb 2022 11:19:47 +0000 Subject: [PATCH 1/2] Use log4j 2.17.1 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index c042df0..b647565 100644 --- a/pom.xml +++ b/pom.xml @@ -32,17 +32,17 @@ 1.8.1 - + org.apache.logging.log4j log4j-1.2-api - 2.15.0 + 2.17.1 test org.apache.logging.log4j log4j-slf4j-impl - 2.15.0 + 2.17.1 test From 0923e82668feeb7dfb2b7143b5ca6f93a2a832bd Mon Sep 17 00:00:00 2001 From: Padraig Gleeson Date: Mon, 28 Feb 2022 11:00:24 +0000 Subject: [PATCH 2/2] Test on windows-2019 --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d1864f..16076eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: fail-fast: false matrix: java: [ '8', '11', '16', '17' ] - runs-on: [ubuntu-latest, macos-11, windows-latest ] + runs-on: [ubuntu-latest, macos-11, windows-2019 ] name: Test on Java ${{ matrix.Java }} on ${{ matrix.runs-on }} steps: @@ -29,7 +29,7 @@ jobs: distribution: 'adopt' - name: Install using getNeuroML.py (non Win) - if: ${{ matrix.runs-on != 'windows-latest' }} + if: ${{ matrix.runs-on != 'windows-2019' }} run: | export main_repo_branch=${{env.main_repo_branch}} if [[ ${main_repo_branch} != "master" && ${main_repo_branch} != "development" && ${main_repo_branch} != "experimental" && ${main_repo_branch} != *"osb"* ]]; then main_repo_branch=development ; fi @@ -40,7 +40,7 @@ jobs: ./jnml -v - name: Install using getNeuroML.py (Win) - if: ${{ matrix.runs-on == 'windows-latest' }} + if: ${{ matrix.runs-on == 'windows-2019' }} run: | $env:main_repo_branch=$env:GITHUB_REF_NAME if ( $env:main_repo_branch -ne "master" -and $env:main_repo_branch -ne "development" -and $env:main_repo_branch -ne "experimental" -and $env:main_repo_branch -notlike '*osb*' ) { $env:main_repo_branch="development" } @@ -52,7 +52,7 @@ jobs: .\jnml.bat -v - name: Further tests (non Win) - if: ${{ matrix.runs-on != 'windows-latest' }} + if: ${{ matrix.runs-on != 'windows-2019' }} run: | pwd ls -alt @@ -72,7 +72,7 @@ jobs: ls -alt ../NeuroML2/LEMSexamples - name: Further tests (Win) - if: ${{ matrix.runs-on == 'windows-latest' }} + if: ${{ matrix.runs-on == 'windows-2019' }} run: | pwd mkdir results