Add missing --hash-algo flag to nix store add
#9809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
nix-store-add-algo
branch
from
f03b49c to
472cbd1
Compare
github-actions
bot
added
the
with-tests
|
Maybe --algorithm to match the adjacent word flags, plus docs on what the options are? By the way it looks like —name and —mode above are both using -n as the short flag 😬
…On Fri, Jan 19, 2024, at 1:19 AM, John Ericson wrote:
Motivation
This is a paramter to the underlying `addToStore` that we forgot to expose
Context
Was supposed to have been part of #8915 <#8915>.
Priorities and Process
Add 👍 to pull requests you find important <https://github.com/NixOS/nix/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc>.
The Nix maintainer team uses a GitHub project board <https://github.com/orgs/NixOS/projects/19> to schedule and track reviews <https://github.com/NixOS/nix/tree/master/maintainers#project-board-protocol>.
You can view, comment on, or merge this pull request online at:
#9809
Commit Summary
• f03b49c <f03b49c> Add missing `--algo` flag to `nix store add`
File Changes
(1 file <https://github.com/NixOS/nix/pull/9809/files>)
• *M* src/nix/add-to-store.cc <https://github.com/NixOS/nix/pull/9809/files#diff-345e94108682437ad97f353613e507147c1dc66b4b123067ecf405173b29c0e1> (7)
Patch Links:
• https://github.com/NixOS/nix/pull/9809.patch
• https://github.com/NixOS/nix/pull/9809.diff
—
Reply to this email directly, view it on GitHub <#9809>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLHD5P6BOMAMBXI3VZDYPIGARAVCNFSM6AAAAABCBN3QKKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DSNRZGAZTEMQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
That looks like a cut&paste mistake. |
thufschmitt
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks :)
EDIT: Didn't see @grahamc 's comment. --algorithm might be better indeed. It's an advanced-enough option that we can afford to be very explicit
thufschmitt
added a commit
that referenced
this pull request
Jan 19, 2024
`-n` was an alias for `--mode`, but that seems to just be a copy-paste error as it doesn't make sense. `--mode` probably doesn't need a shorthand flag at all, so remove it. Noticed in #9809 (comment)
|
|
|
|
|
Discussed during the Nix maintainers meeting today:
@Ericson2314 will do the change, then it's good to go |
Ericson2314
force-pushed
the
nix-store-add-algo
branch
from
472cbd1 to
925bd3b
Compare
Ericson2314
changed the title
--algo flag to nix store add--hash-algo for nix store add and nix store convert
Ericson2314
commented
Jan 20, 2024
Ericson2314
force-pushed
the
nix-store-add-algo
branch
3 times, most recently
from
43bf9c5 to
334312b
Compare
Ericson2314
changed the title
--hash-algo for nix store add and nix store convert--hash-algo flag to nix store add
Ericson2314
force-pushed
the
nix-store-add-algo
branch
from
334312b to
356352c
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-01-19-nix-team-meeting-minutes-116/38837/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a paramter to the underlying
addToStorethat we forgot to exposeContext
Was supposed to have been part of #8915.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.