-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fastfetch] Replace hard coded paths #308849
Comments
Hi thanks for the detailed issue report! |
Done.
|
https://github.com/fastfetch-cli/fastfetch/releases/tag/2.11.3 was released with |
Many thanks! Much appreciated. |
Describe the bug
Fastfetch uses
hwdata/pci.ids
andlibdrm/amdgpu.ids
to convert PCI device ID to human-readable product name.Currently their paths are hard coded as
/usr/share/hwdata/pci.ids
and/usr/share/libdrm/amdgpu.ids
. It won't work with NixOS of course.https://github.com/fastfetch-cli/fastfetch/blob/dev/src/detection/gpu/gpu_linux.c#L126-L137
I found some packages that have similar issues. They are patched directly before building:
nixpkgs/pkgs/tools/graphics/mangohud/hardcode-dependencies.patch
Line 38 in 662ae2a
Fastfetch needs to be patched too.
Steps To Reproduce
Steps to reproduce the behavior:
N/A
Expected behavior
Fastfetch can properly find
pci.ids
andamdgpu.ids
Screenshots
N/A
Additional context
Reference: fastfetch-cli/fastfetch#855
Fastfetch provided cmake config option
CUSTOM_PCI_IDS_PATH
forpci.ids
but not foramdgpu.ids
. I can add one if needed.Notify maintainers
@chewblacka @r-ryantm
Metadata
N/A
Add a 👍 reaction to issues you find important.
The text was updated successfully, but these errors were encountered: