Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bootspec: adopt the merged RFC-0125 #224489

Merged
merged 2 commits into from
Apr 29, 2023
Merged

nixos/bootspec: adopt the merged RFC-0125 #224489

merged 2 commits into from
Apr 29, 2023

Conversation

RaitoBezarius
Copy link
Member

Description of changes

This removes the feature preview warning, enable by default bootspec, adds a validation flag to prevent Go to go into build-time closure.

This will break all downstream users of bootspec as those changes are not backward-compatible.

It cleans up the tests.

cc @edolstra @sternenseemann (on Go at build-time and validation)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 3, 2023
@github-actions github-actions bot added 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Apr 3, 2023
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/24

@RaitoBezarius RaitoBezarius mentioned this pull request Apr 3, 2023
Closed
12 tasks
cole-h
cole-h reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this incorporates #221893, so that one should be closed I think?

Yep lol I was slightly too late.

@RaitoBezarius
Copy link
Member Author

This PR will be landed once nix-community/lanzaboote#148 is landed and comments are addressed.

@RaitoBezarius RaitoBezarius mentioned this pull request Apr 14, 2023
Merged
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2090

@RaitoBezarius RaitoBezarius marked this pull request as draft April 16, 2023 20:50
@RaitoBezarius RaitoBezarius force-pushed the bootspecv1 branch 3 times, most recently from 00c9947 to 1aa9dcc Compare April 21, 2023 13:00
@RaitoBezarius RaitoBezarius marked this pull request as ready for review April 21, 2023 16:06
@RaitoBezarius
Copy link
Member Author

This PR will be landed once nix-community/lanzaboote#148 is landed and comments are addressed.

We decided to inverse the order of merge because this will take time to go into nixos-unstable-small channel. Therefore, we should aim to merge this first.

@RaitoBezarius RaitoBezarius requested review from cole-h and rnhmjoj April 23, 2023 20:46
@RaitoBezarius
Copy link
Member Author

@cole-h May I ask for your final approval? Let's go. :)

@ofborg ofborg bot requested review from Hoverbear, lheckemann and cole-h April 28, 2023 23:09
@cole-h
Copy link
Member

cole-h commented Apr 29, 2023 •
edited
Loading

@ofborg test bootspec

@RaitoBezarius @cole-h
nixos/bootspec: adopt the merged RFC-0125
29533cd 
This removes the feature preview warning, enable by default bootspec,
adds a validation flag to prevent Go to go into build-time closure.

This will break all downstream users of bootspec as those changes are
not backward-compatible.
@RaitoBezarius @cole-h
bootspec: unstable-2022-12-05 -> 0.1.0
cfecfd6
cole-h
cole-h reviewed Apr 29, 2023
View reviewed changes
cole-h
cole-h approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for your time and patience, I look forward to seeing the next nixos-unstable bump with this :)

@ofborg ofborg bot requested a review from cole-h April 29, 2023 01:05
@cole-h cole-h merged commit 52f1451 into master Apr 29, 2023
@cole-h cole-h deleted the bootspecv1 branch April 29, 2023 01:26
@chuangzhu chuangzhu mentioned this pull request May 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncfavier ncfavier ncfavier left review comments

@grahamc grahamc Awaiting requested review from grahamc

@dasJ dasJ Awaiting requested review from dasJ

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@Hoverbear Hoverbear Awaiting requested review from Hoverbear

@lheckemann lheckemann Awaiting requested review from lheckemann

@cole-h cole-h Awaiting requested review from cole-h

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Nix documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RaitoBezarius @nixos-discourse @cole-h @rnhmjoj @ncfavier @dasJ @SuperSandro2000