Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: add meta.repository attribute to fetchers #300286

Closed
wants to merge 18 commits into from
Closed

stdenv: add meta.repository attribute to fetchers #300286

wants to merge 18 commits into from

Conversation

AndersonTorres
Copy link
Member

Restarting the feature request from lolbinarycat at #293838.

Description of changes

Following the hints from

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: stdenv Standard environment 6.topic: fetch labels Mar 30, 2024
@AndersonTorres
Copy link
Member Author

Why is Nixpkgs manual build failing?

@AndersonTorres AndersonTorres changed the title stdenv: add meta.repository attribute stdenv: add meta.repository attribute (try 2) Mar 30, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 30, 2024
@lolbinarycat
Copy link
Contributor

just a heads up: i'm going to try to fix meta.repository as soon as i get home (less than an hour), before you go reimplententing the entire thing.

also, if you're going to write an alternative implementation, please title the PR something containing "alternative implementation" otherwise it will get very confusing if i open another pr

@AndersonTorres AndersonTorres mentioned this pull request Mar 30, 2024
Merged
13 tasks
@AndersonTorres AndersonTorres changed the title stdenv: add meta.repository attribute (try 2) stdenv: add meta.repository attribute (altenative implementation) Mar 30, 2024
@AndersonTorres
Copy link
Member Author

just a heads up: i'm going to try to fix meta.repository as soon as i get home (less than an hour), before you go reimplententing the entire thing.

Mark me!

also, if you're going to write an alternative implementation, please title the PR something containing "alternative implementation" otherwise it will get very confusing if i open another pr

As you wish.

@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Mar 30, 2024
@AndersonTorres AndersonTorres changed the title stdenv: add meta.repository attribute (altenative implementation) stdenv: add meta.repository attribute (altenative pathway) Mar 30, 2024
@rhendric rhendric mentioned this pull request Apr 6, 2024
Open
3 tasks
@AndersonTorres AndersonTorres changed the title stdenv: add meta.repository attribute (altenative pathway) stdenv: add meta.repository attribute Apr 17, 2024
@AndersonTorres AndersonTorres changed the title stdenv: add meta.repository attribute stdenv: add meta.repository attribute to fetchers Apr 17, 2024
@AndersonTorres AndersonTorres marked this pull request as ready for review April 17, 2024 23:27
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4123

@AndersonTorres
fetchFrom9Front: set meta.repository attribute
d00a62d 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromBitbucket: set meta.repository attribute
6c35c03 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitHub: set meta.repository attribute
c3dfb8e 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitLab: set meta.repository attribute
29dda67 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitiles: set meta.repository attribute
316601d 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromRepoOrCz: set meta.repository attribute
7c23ebd 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromSavannah: set meta.repository attribute
3bcfe2a 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromSourceHut: set meta.repository attribute
8e7454b 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres AndersonTorres mentioned this pull request Jul 29, 2024
Closed
13 tasks
@AndersonTorres AndersonTorres deleted the meta-repository-try2 branch July 29, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@piegamesde piegamesde Awaiting requested review from piegamesde

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndersonTorres @lolbinarycat @nixos-discourse