Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imfile: init at 1.1.0 #314821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

imfile: init at 1.1.0 #314821

wants to merge 2 commits into from

Conversation

Zh40Le1ZOOB
Copy link

Description of changes

imFile is a aria2 based download manager, it's a fork of Motrix.

homepage

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 26, 2024
@h7x4
Copy link
Member

h7x4 commented May 26, 2024

I believe you have an accidental file named {}

@Zh40Le1ZOOB
Copy link
Author

I believe you have an accidental file named {}

Oh, you are right. This is ridiculous...

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 26, 2024
@Zh40Le1ZOOB Zh40Le1ZOOB force-pushed the imfile branch 2 times, most recently from ca5766d to 7d6a66a Compare May 26, 2024 13:38
@@ -0,0 +1,70 @@
{ lib
, stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format with the new formatter.

'';

meta = with lib; {
description = "A full-featured download manager";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "A full-featured download manager";
description = "Full-featured download manager";

license = licenses.mit;
platforms = [ "x86_64-linux" "aarch64-linux" "armv7l-linux" ];
mainProgram = "imfile";
maintainers = with maintainers; [ Zh40Le1ZOOB ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = with maintainers; [ Zh40Le1ZOOB ];
maintainers = with maintainers; [ Zh40Le1ZOOB ];
sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];

@DarkReaperBoy
Copy link

#314821 seems like this pr exists for more than 7 months ago, rip

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants