imageworsener: modernize and fetch source from GitHub

[emilazy]

Description of changes

It’s been a while since I was maintaining stuff, so get back into the swing of things a bit by tidying up a little leaf package of mine. No new version, though.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[syvb]

Result of nixpkgs-review pr 325095 run on x86_64-linux 1

1 package built:

• imageworsener

[syvb]

I think this results in a changelog URL like https://entropymine.com/imageworsener/blob/6a43f725425bec281ccca7f5c690379c680e7fa2/changelog.txt, which 404s?

[emilazy]

Nope, because of the .src; a fetchFromGitHub’s homepage points to the GitHub repository, which is correct and reduces redundancy in the case that the repository information is changed or overridden:

emily@yuyuko ~/D/nixpkgs ((c1aad9eb))> nix eval .#imageworsener.meta.changelog
"https://github.com/jsummers/imageworsener/blob/1.3.5/changelog.txt"

Perhaps getting a little too clever, but I liked it :)

[emilazy]

Need to review #277994 before I feel confident about merging this.

[emilazy]

Removed the use of finalAttrs.pname (although I think the $out/share/doc one might have actually been okay); this should be good to go now. The changelog definition really wants the meta.repository field, but that’s in limbo.