Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload new meta repository attribute #330756

Closed
wants to merge 18 commits into from
Closed

Upload new meta repository attribute #330756

wants to merge 18 commits into from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Cleaning the work from #300286
Closes #293838 hopefully

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres AndersonTorres marked this pull request as ready for review July 29, 2024 02:12
@AndersonTorres
Copy link
Member Author

Alternative, competing implementation:
#301947

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 29, 2024
@AndersonTorres
stdenv: add meta.repository attribute
48f4245
@AndersonTorres
stdenv: set repository as an empty list by default
52e8b62
@AndersonTorres
fetchbzr: set meta.repository attribute
66aabb4
@AndersonTorres
fetchcvs: set meta.repository attribute
eeadfba
@AndersonTorres
fetchdarcs: set meta.repository attribute
5ed14c7
@AndersonTorres
fetchfossil: set meta.repository attribute
72c6238
@AndersonTorres
fetchgit: set meta.repository attribute
74ad1fd
@AndersonTorres
fetchhg: set meta.repository attribute
da00faf
@AndersonTorres
fetchpijul: set meta.repository attribute
34d54b2
@AndersonTorres
fetchsvn: set meta.repository attribute
a35bb61
@AndersonTorres
fetchFrom9Front: set meta.repository attribute
3dd1044 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromBitbucket: set meta.repository attribute
7a12eef 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitHub: set meta.repository attribute
81aecc3 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitLab: set meta.repository attribute
dfd4ffe 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromGitiles: set meta.repository attribute
67d1098 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromRepoOrCz: set meta.repository attribute
08115b6 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromSavannah: set meta.repository attribute
5b4c6f0 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres
fetchFromSourceHut: set meta.repository attribute
a8bd8f2 
So that it can be "inherited" by the caller.

Set it to a list so that it can be "expanded".
@AndersonTorres AndersonTorres force-pushed the upload-new-meta-repository-attribute branch from 20ff948 to a8bd8f2 Compare August 7, 2024 01:43
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Aug 7, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@AndersonTorres
Copy link
Member Author

Closing since it does not matter anymore.

@AndersonTorres AndersonTorres deleted the upload-new-meta-repository-attribute branch November 18, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: fetch 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: new meta attr for source code repository
2 participants
@AndersonTorres @wegank