Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet should include the files emitted during restore in the binary log #12374

Closed
jeffkl opened this issue Jan 19, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5042
Closed

NuGet should include the files emitted during restore in the binary log #12374

jeffkl opened this issue Jan 19, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5042
Assignees
@jeffkl
Labels
Area:Logging Priority:2 Issues for the current backlog. Type:Feature

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Jan 19, 2023

NuGet Product(s) Involved

MSBuild.exe, dotnet.exe

The Elevator Pitch

During a build, it is possible to embed arbitrary files in the binary log. The .NET SDK by default includes the project.assets.json file during build: dotnet/sdk#16840

However, during restore the file does not exist yet so a binlog for just restore can be missing files. NuGet should include these files after restore is complete.

Additional Context and Details

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:Logging Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
Milestone
No milestone
1 participant
@jeffkl