Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static graph-based restore does not respect Interactive option when loading projects #12907

Closed
jeffkl opened this issue Sep 27, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5453
Closed

Static graph-based restore does not respect Interactive option when loading projects #12907

jeffkl opened this issue Sep 27, 2023 · 0 comments · Fixed by NuGet/NuGet.Client#5453
Assignees
@jeffkl
Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Type:Bug
Milestone
6.9

Comments

@jeffkl
Copy link
Contributor

jeffkl commented Sep 27, 2023

NuGet Product Used

MSBuild.exe

Product Version

Any

Worked before?

No

Impact

It's more difficult to complete my work

Repro Steps & Context

Static graph-based restore evaluates MSBuild projects in-process but there previously was not an option for these evaluations to respect being interactive/non-interactive. I fixed this by updating the proper APIs in MSBuild to allow setting this option: dotnet/msbuild#8533

Static graph-based restore will need to compile against MSBuild 17.7+ to see this API and set it based on the user's option.

Verbose Logs

No response
@jeffkl jeffkl added Area:RestoreStaticGraph Issues related to the Static Graph restore Priority:2 Issues for the current backlog. Type:Bug labels Sep 27, 2023
@jeffkl jeffkl self-assigned this Sep 27, 2023
@jeffkl jeffkl mentioned this issue Sep 27, 2023
Open
13 tasks
@jeffkl jeffkl added the Category:Quality Week Issues that should be considered for quality week label Oct 2, 2023
@jeffkl jeffkl mentioned this issue Oct 3, 2023
Merged
8 tasks
@jgonz120 jgonz120 added this to the 6.9 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffkl jeffkl

Labels
Area:RestoreStaticGraph Issues related to the Static Graph restore Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
6.9
Development

Successfully merging a pull request may close this issue.

Respect interactive option when evaluation projects in static graph-based restore NuGet/NuGet.Client
2 participants
@jgonz120 @jeffkl