Pin python version for <= 13.0 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylint pulls a version of wrapt that is broken on Python 3.11. See <GrahamDumpleton/wrapt#196>. This breaks pre-commit for any devs running a modern OS. Because we already pinned flake8 to Python 3.6 to circumvent a similar problem, we now simply do it universally to prevent that whole class of problems. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
pylint pulls a version of wrapt that is broken on Python 3.11. See <GrahamDumpleton/wrapt#196>. This breaks pre-commit for any devs running a modern OS. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
|
Nice, but breaks the CI. |
carmenbianca
force-pushed
the
pin-python
branch
3 times, most recently
from
2f40b63 to
0aa71f0
Compare
Python 3.6 is needed for most pre-commit jobs even when running Python 2.7. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
carmenbianca
force-pushed
the
pin-python
branch
from
0aa71f0 to
b371b0c
Compare
|
No longer breaks CI :) |
yajo
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174