Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate redundant EdmDeltaResourceObject and EdmDeltaComplexObject #1429

Open
gathogojr opened this issue Feb 28, 2025 · 0 comments
Open

Comments

@gathogojr
Copy link
Contributor

Originally, EdmStructuredObject (the base class for EdmEntityObject and EdmComplexObject) did not implement IEdmChangedObject. However, four years ago, a change was introduced through [this commit](ee93798) to make EdmStructuredObject implement IEdmChangedObject. This allowed both EdmEntityObject and EdmComplexObject to represent delta payloads.

As a result, EdmDeltaResourceObject and EdmDeltaComplexObject became redundant and should have been deprecated, as noted in this TODO:
[EdmDeltaResourceObject.cs#L24](https://github.com/OData/AspNetCoreOData/blame/c60d9e0e9f68d23ee8ccd84e854ef7e430fe6edb/src/Microsoft.AspNetCore.OData/Formatter/Value/EdmDeltaResourceObject.cs#L24)

I think we should mark redundant EdmDeltaResourceObject and EdmDeltaComplexObject as obsolete and remove them in the next major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant