Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for additional logo in footer #3134

Closed
6 tasks done
alessioventuriniAND opened this issue Apr 10, 2024 · 0 comments · Fixed by #3227
Closed
6 tasks done

Add option for additional logo in footer #3134

alessioventuriniAND opened this issue Apr 10, 2024 · 0 comments · Fixed by #3227
Assignees
Labels
Breaking changes This PR contains at least one breaking change Enhancement Change of existing feature

Comments

@alessioventuriniAND
Copy link
Contributor

alessioventuriniAND commented Apr 10, 2024

Here's a formatted GitHub issue for your footer component updates:

Title: Update Footer Component for Multiple Logos

Description: Our footer component needs the following updates:

  1. Support Multiple Logos:

    • Allow for two logos instead of just one.
    • Enable setting links for each logo.
  2. Default Layout:

    • The default layout should have the logos positioned next to each other.
  3. Alternative Layout:

    • Add an option to display the logos on opposite sides of the footer.
  4. Consistency with Header Component:

    • Align and standardize this work with the current implementation used in the header component.
    • Follow the multipleLogo implementation:
      • MultipleLogo overrides the default ONS logo if SVGs or images are provided.
      • You can also pass in "ONS logo" to use the default ONS logo.
  5. Focus and Hover States:

    • Ensure that the focus and hover states do not create an extra underline.
    • The highlight color should only wrap the SVG and not its margin.

Tasks:

  • Modify the footer component to support two logos.
  • Implement link settings for each logo.
  • Set default layout to have logos next to each other.
  • Add an option for logos to be displayed on opposite sides of the footer.
  • Standardize implementation with the header component's multipleLogo feature.
  • Ensure the focus and hover states meet the specified requirements.

Additional Information:

  • Follow the existing implementation for multiple logos in the header component.
  • Ensure consistent behavior and appearance across the application.

Similar work was done for the header component, check out that PR #2994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR contains at least one breaking change Enhancement Change of existing feature
Projects
None yet
5 participants