Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project schema repository definition #843

Open
arkid15r opened this issue Feb 15, 2025 · 4 comments
Open

Improve project schema repository definition #843

arkid15r opened this issue Feb 15, 2025 · 4 comments
Assignees
Labels
good first issue Good for newcomers schema

Comments

@arkid15r
Copy link
Collaborator

Describe the solution you'd like

  • Make sure link attributes have uri format.
  • Add corresponding tests for all cases (empty/null/invalid)
@arkid15r arkid15r added good first issue Good for newcomers notify labels Feb 15, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Project Nest Feb 15, 2025
@arkid15r arkid15r removed the notify label Feb 15, 2025
@arkid15r arkid15r moved this from Backlog to Todo in Project Nest Feb 15, 2025
@moodyadi2006
Copy link
Contributor

@arkid15r Can you assign this to me?

@arkid15r arkid15r moved this from Todo to In progress in Project Nest Feb 15, 2025
@samyak003
Copy link
Collaborator

@arkid15r can i work on this issue?

@moodyadi2006
Copy link
Contributor

@arkid15r My approach : In schema_validators.py file, I will add a check that if value is none or "" then return False otherwise return True and it will validate... Or do you want me to create some extra tests for validation in project_test.py file? As per my knowledge those tests are enough to check for any null, empty or invalid URI....
Is my approach correct or I have to use more robust checking?

@moodyadi2006
Copy link
Contributor

Although I am merging a PR for this work and just let me know for further changes

@arkid15r arkid15r moved this from In progress to Todo in Project Nest Feb 18, 2025
@arkid15r arkid15r added good first issue Good for newcomers schema and removed good first issue Good for newcomers labels Feb 18, 2025
@arkid15r arkid15r moved this from Todo to In progress in Project Nest Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers schema
Projects
Status: In progress
Development

No branches or pull requests

3 participants