Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved readme, added badges and centered Nest logo #902

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improved readme, added badges and centered Nest logo #902

wants to merge 4 commits into from
+14 −6

Conversation

jaiakash
Copy link
Contributor

@jaiakash jaiakash commented Feb 20, 2025 •
edited
Loading

Fixes #886

  • Centred header and badges.
  • Add OWASP Nest logo.
  • Add modern-looking badges instead of flat badges.
  • Fix build status badge. (its run-ci-cd.yaml not ci-cd.yaml)
Screenshot 2025-02-20 at 10 22 54 PM

@jaiakash jaiakash requested a review from arkid15r as a code owner February 20, 2025 16:52
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 20, 2025
@jaiakash jaiakash force-pushed the revamp-readme-stats branch from cdfcf15 to 8512e77 Compare February 20, 2025 17:09
@jaiakash jaiakash requested a review from kasya as a code owner February 20, 2025 17:09
@jaiakash
Copy link
Contributor Author

I was squashing the commits; that's why I forced push. It automatically added various labels and tagged Kate Golovanova for code review. I am sorry for that

@arkid15r
Copy link
Collaborator

I was squashing the commits; that's why I forced push. It automatically added various labels and tagged Kate Golovanova for code review. I am sorry for that

@jaiakash don't worry about this 👍

arkid15r
arkid15r reviewed Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep start/forks too?

README.md

![Node 22](https://img.shields.io/badge/Node-22-blue.svg) ![TypeScript](https://img.shields.io/badge/TypeScript-5.7-blue.svg) ![Code Style](https://img.shields.io/badge/ESLint-9.17-blue) ![Code Style](https://img.shields.io/badge/Prettier-3.4.2-blue)
[![OWASP](https://img.shields.io/badge/OWASP-Incubator-blue?style=for-the-badge)](https://owasp.org/www-project-nest/) ![OWASP](https://img.shields.io/badge/OWASP-Code-blue?style=for-the-badge) [![Project-Nest](https://img.shields.io/badge/OWASP-Join%20%23project--nest-8E44AD?logo=slack&logoColor=white&style=for-the-badge)](https://owasp.slack.com/messages/project-nest)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this still works -- I tried to remove "join"

Suggested change
[![OWASP](https://img.shields.io/badge/OWASP-Incubator-blue?style=for-the-badge)](https://owasp.org/www-project-nest/) ![OWASP](https://img.shields.io/badge/OWASP-Code-blue?style=for-the-badge) [![Project-Nest](https://img.shields.io/badge/OWASP-Join%20%23project--nest-8E44AD?logo=slack&logoColor=white&style=for-the-badge)](https://owasp.slack.com/messages/project-nest)
[![OWASP](https://img.shields.io/badge/OWASP-Incubator-blue?style=for-the-badge)](https://owasp.org/www-project-nest/) ![OWASP](https://img.shields.io/badge/OWASP-Code-blue?style=for-the-badge) [![Project-Nest](https://img.shields.io/badge/OWASP-%23project--nest-8E44AD?logo=slack&logoColor=white&style=for-the-badge)](https://owasp.slack.com/messages/project-nest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

@kasya kasya Awaiting requested review from kasya

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readme: improve the readme images and badges
2 participants
@jaiakash @arkid15r