*: electra versioned aggregations #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## electra #3482 +/- ##
==========================================
Coverage ? 55.70%
==========================================
Files ? 218
Lines ? 33725
Branches ? 0
==========================================
Hits ? 18786
Misses ? 12966
Partials ? 1973 ☔ View full report in Codecov by Sentry. |
|
pinebit
approved these changes
Jan 28, 2025
| err := unmarshal(typ, body, denebAtts) | ||
| if err == nil { | ||
| for _, att := range *denebAtts { | ||
| // TODO: Data version is not Deneb, it might be anything between Phase0 and Deneb |
There was a problem hiding this comment.
Flagging this TODO, maybe you forgot to resolve it.
There was a problem hiding this comment.
Unfortunately, I haven't found a nice way yet... It's in my list for things to fix.
With other versioned structures (like blocks), we have a clunky but functional way of resolving the version - we simply try to parse all versions and whichever succeeds, we deem it is that one. However, for attestations, anything between phase0 and Deneb has the exact same structure, so this method won't really work.
DiogoSantoss
approved these changes
Jan 28, 2025
KaloyanTanev
added
the
merge when ready
KaloyanTanev
added a commit
that referenced
this pull request
Jan 31, 2025
* Add electra versioned aggregations * Bump go-eth2-client version and fix TODOs * Write own switch cases, instead of waiting on go-eth2-client util funcs * Fix linter * WIP * Aggregations fixes and tests updates * Fix submitAttestations parsing * Bump go-eth2-client * Fix teku integration test
KaloyanTanev
added a commit
that referenced
this pull request
Feb 5, 2025
* Add electra versioned aggregations * Bump go-eth2-client version and fix TODOs * Write own switch cases, instead of waiting on go-eth2-client util funcs * Fix linter * WIP * Aggregations fixes and tests updates * Fix submitAttestations parsing * Bump go-eth2-client * Fix teku integration test
KaloyanTanev
added a commit
that referenced
this pull request
Feb 7, 2025
* Add electra versioned aggregations * Bump go-eth2-client version and fix TODOs * Write own switch cases, instead of waiting on go-eth2-client util funcs * Fix linter * WIP * Aggregations fixes and tests updates * Fix submitAttestations parsing * Bump go-eth2-client * Fix teku integration test
KaloyanTanev
added a commit
that referenced
this pull request
Feb 10, 2025
* Add electra versioned aggregations * Bump go-eth2-client version and fix TODOs * Write own switch cases, instead of waiting on go-eth2-client util funcs * Fix linter * WIP * Aggregations fixes and tests updates * Fix submitAttestations parsing * Bump go-eth2-client * Fix teku integration test
KaloyanTanev
added a commit
that referenced
this pull request
Feb 24, 2025
* Add electra versioned aggregations * Bump go-eth2-client version and fix TODOs * Write own switch cases, instead of waiting on go-eth2-client util funcs * Fix linter * WIP * Aggregations fixes and tests updates * Fix submitAttestations parsing * Bump go-eth2-client * Fix teku integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the regular aggregations to versioned aggregations. Given that the attestation structure is changing, the one for aggregations does as well.
Some other small things included in this PR:
category: feature
ticket: none