Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: electra #3558

Merged
merged 12 commits into from
Feb 26, 2025
Merged

*: electra #3558

merged 12 commits into from
Feb 26, 2025

Conversation

KaloyanTanev
Copy link
Collaborator

Merge electra branch to main

category: feature
ticket: none

pinebit and others added 12 commits February 24, 2025 12:03
* Comment out gnosis fix

* SubmitAttestation to versioned attestation

* Rework attestations, add BlockAttestationsV2 endpoint, update signed blocks with electra version

* go mod tidy

* Add more random attestation util functions

* Fix duty attester test signatures

* Fix raw attestation json tag

* Fix error messages
* Add electra versioned aggregations

* Bump go-eth2-client version and fix TODOs

* Write own switch cases, instead of waiting on go-eth2-client util funcs

* Fix linter

* WIP

* Aggregations fixes and tests updates

* Fix submitAttestations parsing

* Bump go-eth2-client

* Fix teku integration test
* Add electra version support in all switch cases

* Add more electra tests
* Fix tracker aggregation bits attestations for electra

* Add tests and fix linter

* Remove test file

* Fix final inclusion check

* Fix TestInclusion test block structure
* Support obol fork of go-eth2-client

* Compatible v1 attestations

* Support v1 aggregations on electra

* Fix pre-commit hook

* iota rework
Copy link

sonarqubecloud bot commented Feb 24, 2025

Quality Gate Passed Quality Gate passed

Issues
46 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.4% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 48.09015% with 1359 lines in your changes missing coverage. Please review.

Project coverage is 56.51%. Comparing base (22ce8f0) to head (cf047cb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
core/tracker/inclusion.go 35.79% 235 Missing and 43 partials ⚠️
core/signeddata.go 57.14% 156 Missing and 60 partials ⚠️
core/ssz.go 59.07% 93 Missing and 22 partials ⚠️
app/eth2wrap/httpwrap.go 25.33% 100 Missing and 12 partials ⚠️
core/dutydb/memory.go 51.25% 94 Missing and 3 partials ⚠️
core/fetcher/fetcher.go 30.64% 78 Missing and 8 partials ⚠️
core/validatorapi/router.go 61.80% 75 Missing and 1 partial ⚠️
core/validatorapi/validatorapi.go 49.28% 56 Missing and 15 partials ⚠️
app/eth2wrap/eth2wrap_gen.go 0.00% 57 Missing ⚠️
core/unsigneddata.go 67.61% 48 Missing and 9 partials ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
- Coverage   57.47%   56.51%   -0.97%     
==========================================
  Files         217      218       +1     
  Lines       32298    34765    +2467     
==========================================
+ Hits        18563    19647    +1084     
- Misses      11823    13052    +1229     
- Partials     1912     2066     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 26, 2025
@obol-bulldozer obol-bulldozer bot merged commit 9a914ab into main Feb 26, 2025
14 checks passed
@obol-bulldozer obol-bulldozer bot deleted the electra branch February 26, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants