Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIT-2602] Remove memsize to use Golang 1.23 in Nitro #363

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[NIT-2602] Remove memsize to use Golang 1.23 in Nitro #363

merged 1 commit into from
Oct 1, 2024
+0 −9

Conversation

gligneul
Copy link
Contributor

@gligneul gligneul commented Oct 1, 2024

Related Nitro PR:
OffchainLabs/nitro#2711

Original commit:

internal/debug: remove memsize (#30253)
Removing because memsize will very likely be broken by Go 1.23. See fjl/memsize#4

@gligneul gligneul requested a review from PlasmaPower October 1, 2024 18:38
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

PlasmaPower
PlasmaPower previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge October 1, 2024 18:39
@gligneul gligneul force-pushed the gligneul/upgrade-golang branch from 8e03d3d to 895300e Compare October 1, 2024 18:45
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@gligneul
Copy link
Contributor Author

gligneul commented Oct 1, 2024

I force-pushed to add a missing part from the original commit.

@gligneul gligneul mentioned this pull request Oct 1, 2024
Merged
@fjl @gligneul
internal/debug: remove memsize (#30253)
b068464 
Removing because memsize will very likely be broken by Go 1.23. See
fjl/memsize#4
@gligneul gligneul force-pushed the gligneul/upgrade-golang branch from 895300e to b068464 Compare October 1, 2024 18:53
@cla-bot cla-bot
Copy link

cla-bot bot commented Oct 1, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

PlasmaPower
PlasmaPower approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 4758974 into master Oct 1, 2024
5 of 6 checks passed
@PlasmaPower PlasmaPower deleted the gligneul/upgrade-golang branch October 1, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
design-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gligneul @PlasmaPower @fjl