Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Migration Bot RSC to Python #1563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mohammed-MSFT
Copy link
Contributor

No description provided.

@Mohammed-MSFT Mohammed-MSFT requested a review from Copilot February 7, 2025 10:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 20 out of 34 changed files in this pull request and generated 1 comment.

Files not reviewed (14)
  • samples/bot-receive-channel-messages-withRSC/python/.env: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/.gitignore: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/.vscode/extensions.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/.vscode/launch.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/.vscode/settings.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/.vscode/tasks.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/appManifest/manifest.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/assets/sample.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/env/.env.local: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/infra/azure.bicep: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/infra/azure.parameters.json: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/requirements.txt: Language not supported
  • samples/bot-receive-channel-messages-withRSC/python/README.md: Evaluated as low risk
  • samples/bot-receive-channel-messages-withRSC/python/app.py: Evaluated as low risk
Comments suppressed due to low confidence (4)

samples/bot-receive-channel-messages-withRSC/python/bots/botActivityHandler.py:14

  • [nitpick] The variable name 'sampleDescription' does not follow PEP8 naming conventions. It should be renamed to 'sample_description'.
self.sampleDescription = "With this sample your bot can receive user messages across standard channels in a team without being @mentioned"

samples/bot-receive-channel-messages-withRSC/python/bots/botActivityHandler.py:15

  • [nitpick] The variable name 'option' does not follow PEP8 naming conventions. It should be renamed to 'option_text'.
self.option = "Type 1 to know about the permissions required,  Type 2 for documentation link"

samples/bot-receive-channel-messages-withRSC/python/bots/botActivityHandler.py:16

  • [nitpick] The variable name 'permissionRequired' does not follow PEP8 naming conventions. It should be renamed to 'permission_required'.
self.permissionRequired = "This capability is enabled by specifying the ChannelMessage.Read.Group permission in the manifest of an RSC enabled Teams app"

samples/bot-receive-channel-messages-withRSC/python/bots/botActivityHandler.py:17

  • [nitpick] The variable name 'docLink' does not follow PEP8 naming conventions. It should be renamed to 'doc_link'.
self.docLink = "https://docs.microsoft.com/en-us/microsoftteams/platform/bots/how-to/conversations/channel-messages-with-rsc"

Copy link
Contributor

@Jegadeesh-MSFT Jegadeesh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants