Extract Dev OMNI/MSC calculations to calculate_devmsc() a standalone, "pure" function #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the Dev OMNI/MSC calculation into a standalone, pure function that simply performs the algebra needed for the calculation. * Make `static const` values for 3 values used in the calculations * Actual behavior/computations should be unchanged * Update/improve comments These changes make the code more readable, maintainable, and testable. Specifically we should be able to add unit tests of the calculate_devmsc() function to verify spec conformance and investigate possible rounding errors.
msgilligan
force-pushed
the
msgilligan-refactor-update_devmsc
branch
from
15cd53b to
8517485
Compare
dexX7
approved these changes
Dec 17, 2021
counos
pushed a commit
to CounosH/counoslayer
that referenced
this pull request
Sep 27, 2023
…devmsc() a standalone, "pure" function Pull request description: * Move the Dev OMNI/MSC calculation into a standalone, pure function that simply performs the algebra needed for the calculation. * Make `static const` values for 3 values used in the calculations * Actual behavior/computations should be unchanged * Update/improve comments These changes make the code more readable, maintainable, and testable. Specifically we should be able to add unit tests of the calculate_devmsc() function to verify spec conformance and investigate possible rounding errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Dev OMNI/MSC calculation into a standalone, pure function that
simply performs the algebra needed for the calculation.
Make
static constvalues for 3 values used in the calculationsActual behavior/computations should be unchanged
Update/improve comments
These changes make the code more readable, maintainable, and testable.
Specifically we should be able to add unit tests of the calculate_devmsc()
function to verify spec conformance and investigate possible rounding errors.