Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omnisharp doesn't respect InternalsVisibleTo #886

Closed
TyOverby opened this issue Jun 6, 2017 · 3 comments
Closed

Omnisharp doesn't respect InternalsVisibleTo #886

TyOverby opened this issue Jun 6, 2017 · 3 comments

Comments

@TyOverby
Copy link

TyOverby commented Jun 6, 2017

When I attempt to load a bunch of projects from vscode I get errors everywhere for inaccessibility due to protection level. These projects build just fine on the command line, and load in VS without issue.

@DustinCampbell
Copy link
Contributor

@TyOverby: OmniSharp should support InternalsVisibleTo just fine. Is it possible that the project you're loading is Roslyn? In Roslyn, the InternalsVisibleTo attributes are generated via MSBuild tasks, which OmniSharp won't run today.

@TyOverby
Copy link
Author

TyOverby commented Jun 6, 2017

@DustinCampbell Ah, that'd be the issue then! Is there any workaround?

@TyOverby TyOverby closed this as completed Jun 6, 2017
@DustinCampbell
Copy link
Contributor

Not yet, the problem is that OmniSharp needs to run the "Compile" target as a design-time build. Today, it just runs the ResolveAssemblyReferences target. I tried switching it, but ran into some complexities, so it'll take a bit more effort.

I'm looking into this as part of dotnet/vscode-csharp#1531.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants