Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't ignore "Code Issue" #242

Closed
Zedespook opened this issue Sep 11, 2018 · 6 comments
Closed

Can't ignore "Code Issue" #242

Zedespook opened this issue Sep 11, 2018 · 6 comments

Comments

@Zedespook
Copy link

In the config.json configuration, I wrote this:

"^Comparison of floating point numbers can be unequal due to the differing precision of the two values.*"

And after that, my code wouldn't load in for OmniSharp. Maybe it's just with me, or I mistyped something, but can somebody help me out?

@Rosalie241
Copy link
Contributor

I don't understand what you've tried, please explain it/post the full configuration file(and the path of it).
Also please explain what you're trying to do.

@Zedespook
Copy link
Author

C:\Users\vassz\AppData\Roaming\Sublime Text 3\Packages\OmniSharp\PrebuiltOmniSharpServer\config.json

"IgnoredCodeIssues": [

     "^Keyword 'private' is redundant. This is the default modifier.$",
     ".* should not separate words with an underscore.*",
     "^Redundant argument name specification$",
     "^Convert to '.*' expre.",
     "^Use 'var' keyword$",
     "^Name should have prefix.",
     "^Redundant ToString.",
     "^Initializing field by default value is redundant$",
     "^Parameter can be IComparable$",
     "^Convert to constant.*",
     "^Convert to readonly*",
     "^Variable could be moved to a nested scope$",
     ".* Method never reaches its end or a 'return' statement.$",
     ".* should start with an upper case letter. \\(Rule 'Enum Members'\\)$"
 ],

@Rosalie241
Copy link
Contributor

Rosalie241 commented Sep 28, 2018

Alright, omnisharp-server has been deprecated for a long time now,

I'm the new maintainer so I just updated omnisharp-roslyn(also removed omnisharp-server)

and it seems like you can't ignore code issues in omnisharp-roslyn yet: OmniSharp/omnisharp-roslyn#301

I'll most likely release a new version of omnisharp-sublime soon, need to fix a few things and test some more. But while you're at it, you can try the latest master.

@Zedespook
Copy link
Author

Alright, omnisharp-server has been deprecated for a long time now,

I'm the new maintainer so I just updated omnisharp-roslyn(also removed omnisharp-server)

and it seems like you can't ignore code issues in omnisharp-roslyn yet: OmniSharp/omnisharp-roslyn#301

I'll most likely release a new version of omnisharp-sublime soon, need to fix a few things and test some more. But while you're at it, you can try the latest master.

I'm testing it, so far I had some technical problems installing it, but after a while, it just started working again. So this is not a problem, although warnings are not popping up. Which is not really the big thing, but I liked it in the older releases. Is it going to come back later on? Or removed completely?

@Rosalie241
Copy link
Contributor

I don't want to maintain a deprecated tool in this repo, so it's gone forever.

I did not change how warnings/errors work, the panel should pop up like usual.

@Rosalie241
Copy link
Contributor

Alright, I'll close this since this is not my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants