BRepTools_NurbsConvertModification::NewPolygon does not return false when creation fails

[dpasukhi]

Description

Beginning in OpenCASCADE v7.7, the method BRepTools_NurbsConvertModification::NewPolygon can fail to create a curve, but return Standard_True anyway. This is FreeCAD bug 9760: https://github.com/FreeCAD/FreeCAD/issues/9760.

Original issue: https://tracker.dev.opencascade.org/view.php?id=33576

A possible fix is to add a return Standard_False; instead of ignoring the bad edges.

Expected Behavior

Marking as invalid shape

Actual Behavior

The shape is valid

Sample Code or DRAW Tcl Script

pload ALL
bsplinecurve bc 2 2 0 3 1 3 0 3 0 1 5 9 0 1 12 4 0 1
mkedge e1 bc
incmesh e1 0.03
nurbsconvert nb e1
checkshape nb

Result using OpenCASCADE 7.6.3:
This shape seems to be valid

Result using 7.7 and later:
On Shape faulty_1 :
BRepCheck_No3DCurve
BRepCheck_CheckFail

Faulty shapes in variables faulty_1 to faulty_1

Operating System

Linux

Compiler

GCC

Bitness

64-bit

OCCT Version

latest

Additional Files

No response