feat: add more cache info

[bigdaronlee163]

list redis cache and block cache of rocksdb on info data
used memory caculate blockcache && rediscache
and list redis cache and block cache in new line

Summary by CodeRabbit

• New Features

  • Enhanced memory metrics output to include detailed Redis and block cache usage.
  • Added human-readable memory usage statistics.

• Bug Fixes

  • Improved accuracy of memory usage reporting by incorporating additional cache metrics.

[coderabbitai]

Walkthrough

The recent updates primarily involve the InfoCmd::InfoData function in the src/pika_admin.cc file, adding new variables and calculations to track Redis and block cache usage, which are then included in the memory metrics output. Additionally, a new constant was introduced in storage.h to support these changes.

Changes

File	Change Summary
src/pika_admin.cc	Added variables and calculations to track and output Redis and block cache usage in the InfoCmd::InfoData function.
src/storage/include/storage.h	Introduced a new constant PROPERTY_TYPE_ROCKSDB_BlOCK_CACHE_USAGE for tracking block cache usage.

Poem

🐇 Amidst the code where bytes align,
New caches count, results refine.
Memory whispers, metrics sing,
Redis and blocks, clarity bring.
With changes made, the data's clear,
Hail to progress, let's all cheer! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1de6598 and 5f08643.

Files selected for processing (2)

• src/pika_admin.cc (3 hunks)
• src/storage/include/storage/storage.h (1 hunks)

Files skipped from review due to trivial changes (1)

• src/storage/include/storage/storage.h

Additional comments not posted (8)

src/pika_admin.cc (8)

1261-1261: Initialize total_redis_cache_usage variable.

The variable total_redis_cache_usage is initialized to track the total Redis cache usage.

---

1262-1262: Initialize total_block_cache_usage variable.

The variable total_block_cache_usage is initialized to track the total block cache usage.

---

1265-1266: Initialize redis_cache_usage and block_cache_usage variables.

These variables are initialized to track the Redis and block cache usage for each database.

---

1277-1277: Retrieve block cache usage.

The block cache usage is retrieved using PROPERTY_TYPE_ROCKSDB_BlOCK_CACHE_USAGE.

---

1279-1279: Retrieve Redis cache usage.

The Redis cache usage is retrieved from the database's cache info.

---

1283-1284: Accumulate block cache and Redis cache usages.

The total block cache and Redis cache usages are accumulated for all databases.

---

1294-1295: Include cache usages in memory metrics.

The total memory usage now includes the Redis and block cache usages, and these metrics are incorporated into the output stream.

---

1298-1299: Output cache usage metrics.

The Redis and block cache usages are included in the output stream.