Pick up Codis to Pika. #1279
Merged
Pick up Codis to Pika. #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wyatt Jia <[email protected]>
Signed-off-by: Wyatt Jia <[email protected]>
Signed-off-by: Wyatt Jia <[email protected]>
Signed-off-by: Wyatt Jia <[email protected]>
|
能编译过就行。jemalloc-go可以后面再加 |
|
🙋 I have some familiarity with Golang. |
ok |
|
滴滴 |
|
大佬，带我一个，我有在生产用codis+pika |
|
接触过一些codis，混个脸熟 |
|
滴滴 想尽自己所能参与一下 |
|
@kernelai 这个改动是不是和已有的改动https://github.com/kernelai/codis/tree/release3.2-dev 不兼容，是不是得合并一下 |
不兼容的地方比较多。后面的pr可以把特性慢慢合进来。这个pr 可以主要解决codis的代码能合并到pika仓库，解决go mod的问题。 |
|
接触过codis |
Signed-off-by: Wyatt Jia <[email protected]>
Signed-off-by: Wyatt Jia <[email protected]>
Signed-off-by: Wyatt Jia <[email protected]>
wanghenshui
approved these changes
Feb 28, 2023
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
Signed-off-by: Wyatt Jia <[email protected]>
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Wyatt Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to relocate the codis project to Pika and removed the redis dependency and upgraded to the go module. At the moment, the dependency jemalloc-go for compiling codis in the makefile of codis has not been modified yet, so the subsequent make process has not been verified yet. If you are familiar with go module and makefile, you can help to finish this pull request.