Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building against latest nginx breaks #49

Closed
anpin opened this issue May 31, 2024 · 2 comments
Closed

Building against latest nginx breaks #49

anpin opened this issue May 31, 2024 · 2 comments
Assignees

Comments

@anpin
Copy link

anpin commented May 31, 2024

nginx has removed r->port_start and r->port_end.

nginx/nginx@0db94ba

src/server/nginx.c: In function '_oauth2_nginx_port_copy':
src/server/nginx.c:103:27: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'port_end'; did you mean 'host_end'?
  103 |         int len = ctx->r->port_end - ctx->r->port_start;
      |                           ^~~~~~~~
      |                           host_end
src/server/nginx.c:103:46: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'port_start'; did you mean 'host_start'?
  103 |         int len = ctx->r->port_end - ctx->r->port_start;
      |                                              ^~~~~~~~~~
      |                                              host_start
src/server/nginx.c:105:58: error: 'ngx_http_request_t' {aka 'struct ngx_http_request_s'} has no member named 'port_start'; did you mean 'host_start'?
  105 |                 v = oauth2_strndup((const char *)ctx->r->port_start, len);
      |                                                          ^~~~~~~~~~
      |                                                          host_start
make: *** [Makefile:1464: src/server/liboauth2_nginx_la-nginx.lo] Error 1

@zandbelt zandbelt self-assigned this May 31, 2024
@anpin anpin changed the title Building latest nginx breaks Building against latest nginx breaks May 31, 2024
@anpin
Copy link
Author

anpin commented May 31, 2024

@zandbelt thank you for the swift response

@zandbelt
Copy link
Member

zandbelt commented Jun 5, 2024

this needed another fix (the remote port was used instead of the local one...) ; that is in a new release 1.6.2 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants