TypeError: Unsupported operand types: int * string

[m-overlund]

You can crash the admin product page, by filtering for Price from: NULL to: NULL

TypeError: Unsupported operand types: int * string
https://bmb-import.sentry.io/share/issue/7fb970b852054849b8f142c3baeaecdb/

PHP 8.1
OpenMage 19.4.23

(Happens with and without TBT_EnhancedGrid)

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

1. [Screenshots, logs or description]

Actual result (*)

1. [Screenshots, logs or description]

[fballiano]

would it be possible to test with the latest github version?

[m-overlund]

i don't have the greatest dev setup atm. - but will try to prioritize this :)

[elidrissidev]

Filtering by NULL is a new feature added by #1203, and I don't think it supports custom column filter classes.

[sreichel]

@elidrissidev it happens for all strings - not only null.

[elidrissidev]

Yeah but it wouldn't make sense to filter by a string in a Price column...

[addison74]

From an engineering point of view, filtering by any value, other than numerical, must be avoided. As it is now in Backend the error appears and I get the popup with the animated loader and "Please wait..." message. If I refresh the page, all the content under the navigation menu disappears. I have to end the session and login again. Obviously such a situation must be prevented and we should not rely on the honesty of the user to use only numerical/dates values when filtering the grid columns.

[sreichel]

@all-contributors add @m-overlund bug

[allcontributors]

@sreichel

I've put up a pull request to add @m-overlund! 🎉