Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ECDSA tests #1667

Closed
nventuro opened this issue Mar 7, 2019 · 1 comment · Fixed by #2619
Closed

Improve ECDSA tests #1667

nventuro opened this issue Mar 7, 2019 · 1 comment · Fixed by #2619
Labels
tests Test suite and helpers.

Comments

@nventuro
Copy link
Contributor

nventuro commented Mar 7, 2019

#1622 introduced some changes to the ECDSA contract, and made it clear that our test suite for that particular contract is somewhat lacking. We should refactor it so that:

  • it's easy for users to understand how to use the contract (i.e. how to generate signatures e.g. using web3.eth.sign)
  • all cases are properly covered (all combinations of valid and invalid s and v values)
@nventuro nventuro added improvement tests Test suite and helpers. labels Mar 7, 2019
@frangio
Copy link
Contributor

frangio commented Mar 12, 2019

Your first point we should tackle with documentation rather than tests IMO, but both things will help.

@frangio frangio mentioned this issue Apr 13, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ECDSA tests and docs Amxx/openzeppelin-contracts
2 participants
@frangio @nventuro