Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Pattern list smart search with new app/ structure #348

Open
redxeth opened this issue Jul 29, 2019 · 3 comments
Open

Issue with Pattern list smart search with new app/ structure #348

redxeth opened this issue Jul 29, 2019 · 3 comments
Labels

Comments

@redxeth
Copy link
Member

redxeth commented Jul 29, 2019

When doing pattern generation, Origen has generally always been able to find a pattern list located in the list/ directory without having to give the full relative path. I.e.

origen g test.list

works just like:

origen g list/test.list

if test.list is indeed located in list/ dir at the top level of your app/plugin.

However, with the new app/ directory structure recommended for use since v0.50.0, it makes more sense to put the pattern list directory under the app/ directory.

However, this currently doesn't work:

origen g test.list

if test.list is located in app/list/.

Of course, an explicit path still works:

origen g app/list/test.list

This perhaps should be fixed for the new recommended app/ structure to work with either list/ (for backward compatibility) and app/list (or a different name that's more clear while we're at it).


Also-- to note another interesting thing (perhaps by intention) when attempting to generate a pattern list contained in a plugin from a higher level Origen application without indicating the relative path, it only works for the list/ directory in the toplevel app.

I.e. this works from toplevel app:

origen g test.list

if test.list file is located in list/ of toplevel, but not if test.list is located in list/ dir of plugin (even with plugin active).

It does work if you are explicit with the path:

origen g list/test.list

if test.list is in list/ of plugin.

Perhaps this is by design, just thought I would mention it in case we want the smart search to also look in directories in the active plugin.

@redxeth
Copy link
Member Author

redxeth commented Jul 29, 2019

Just noticed also that by default the default output dir for referenced.list also needs to be changed for the new app/ directory structure.

@info-rchitect
Copy link
Member

@redxeth Can we also make the web compile command backwards compatible with lib/templates?

@redxeth
Copy link
Member Author

redxeth commented Jul 29, 2019

It isn't ?

@redxeth redxeth added the bug label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants