Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anyone using the ChipPackage class for anything besides the add_package method? #408

Open
info-rchitect opened this issue Nov 6, 2020 · 4 comments
Assignees
Labels

Comments

@info-rchitect
Copy link
Member

info-rchitect commented Nov 6, 2020

Hi,

The ChipPackage class is created when you add a package via the add_package method. However there is no initialization method and the add_package method handles some of what a typical initialization method would do.

There are also many methods and class attributes related to plotting the package in the console. Has anyone besides the original co-op at FSL who wrote the code used this code? I doubt it as I don't think the code is actually functional based on my attempt at using it. I think the port from RGen to Origen may have missed some stuff as there are no spec tests for this code.

The reason I ask is because I am looking at refactoring this and want to see how much leeway I have.

thx

@pderouen
Copy link
Member

pderouen commented Nov 9, 2020

@info-rchitect I haven't used it.

@rlaj
Copy link
Member

rlaj commented Nov 9, 2020

Same here. I used add_package a few times, but never went further than that.

@priyavadan
Copy link
Member

@info-rchitect what's the latest on this issue ?

@info-rchitect
Copy link
Member Author

@priyavadan Still working on the code, made some progress but other things got in the way. Can revisit in a couple weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants