Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in Comparator doesn't work for referenced.list file. #429

Open
redxeth opened this issue Jul 8, 2021 · 0 comments
Open

Built-in Comparator doesn't work for referenced.list file. #429

redxeth opened this issue Jul 8, 2021 · 0 comments
Assignees
Labels

Comments

@redxeth
Copy link
Member

redxeth commented Jul 8, 2021

In working on a project today found that if ONLY the referenced.list file that gets generated by origen program command is different from its reference, then Origen.app.stats.changed_files is not updated.

It updates Origen.app.stats.changed_patterns instead but since there really wasn't a pattern generation executed then the number of completed patterns is 0 so the changed file isn't caught.

Usually this isn't a problem since if your program is messed up enough to cause a difference in the referenced.list then the program files will fail the difference check and be caught. But we had a strange case where the referenced.list used as a reference changed and thus a change was indicated in the log, but the overall comparison didn't fail.

@redxeth redxeth added the bug label Jul 8, 2021
@redxeth redxeth changed the title Built-in Comparitor doesn't work for referenced.list file. Built-in Comparator doesn't work for referenced.list file. Jul 8, 2021
@redxeth redxeth self-assigned this Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant