Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid certain types for directive (should be configurable) with an optional replacement #1334

Open
OskarStark opened this issue Mar 7, 2023 · 3 comments

Comments

@OskarStark
Copy link
Owner

Spotted in

cc @alamirault

@OskarStark OskarStark changed the title Forbid certain types for directive (should be configurable= with an optional replacement Forbid certain types for directive (should be configurable) with an optional replacement Mar 7, 2023
@OskarStark
Copy link
Owner Author

Or we can create a rule which only allows x,y,z type for directive N, maybe that's better, because the input can differ (typos etc.)

@MrYamous
Copy link
Collaborator

MrYamous commented Mar 7, 2023

Hello :)
I looked at the existing rules when making the pr on docs. The attribute was spotted as non existent so i guess job was done, wasn't ?

@OskarStark
Copy link
Owner Author

No I am thinking about a rule where the project can define allowed code-block directive types.

Symfony would allow:
php-attributes
php-standalone
yaml

Etc.

The referenced PR would then fail with sth like:

"Type "attribute" is not allowed for code-block directive. Allowed ones are: ......"

I hope it's more clear now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants