Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unused .inc files #969

Open
OskarStark opened this issue May 13, 2021 · 4 comments
Open

Check for unused .inc files #969

OskarStark opened this issue May 13, 2021 · 4 comments

Comments

@OskarStark
Copy link
Owner

Follows symfony/symfony-docs#15336

@iamvar
Copy link

iamvar commented May 13, 2021

I am not sure that this check should be part of doctor-rst as rst files itself are valid.
Maybe this should be separate github action in symfony-docs that checks such cases.
I used simple bash script to find them.

@OskarStark
Copy link
Owner Author

Sure but DOCtor ist not about valid or not but about linting.

Let's say we want to ensure only one blank line max, 2 blank lines are valid too.

So why shouldn't this fit here?

@iamvar
Copy link

iamvar commented May 13, 2021

It can, but from my perspective, it is a separate thing.
You can try to fit it there.
Moreover rst does not specify which extension should included file be, it is .inc in Symfony case, but theoretically, it can be .rts

@OskarStark
Copy link
Owner Author

We can make the extension it configurable.

We have nearly the same rule where we want to report LinkDefinitions which are not used anymore. It's some kind of dead code and should not be maintained anymore/in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants