French indicator metadata cleanup #930

Zeitsperre · 2021-11-17T21:50:25Z

Pull Request Checklist:

This PR addresses an already opened issue (for bug fixes / features)
- This PR fixes Better French indicator translations #929
Tests for the changes have been added (for bug fixes / features)
Documentation has been added / updated (for bug fixes / features)
HISTORY.rst has been updated (with summary of main changes)
- Link to issue (:issue:number) and pull request (:pull:number) has been added.
bumpversion patch has been called on this branch
The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

removed a bunch of empty comment strings among the French translations
lots of grammar and phrasing changes to

Does this PR introduce a breaking change?

Yes. Many indicators translated to French will no longer have the same spelling/phrasing in their metadata fields.

Other information:

coveralls · 2021-11-17T22:33:25Z

Pull Request Test Coverage Report for Build 1505909016

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.264%

Totals
Change from base Build 1505461474:	0.0%
Covered Lines:	12664
Relevant Lines:	14030

💛 - Coveralls

juliettelavoie · 2021-11-17T22:02:06Z

xclim/data/fr.json

-    "title": "Moyenne de la température journalière moyenne",
-    "comment": "",
-    "abstract": "Moyenne de la température journalière moyenne."
+    "long_name": "Moyenne de la température journalière",


Is there a reason sometimes it is "quoditienne" et sometimes "journalière" ?

From what I understand, it has something to do with the context and the repetitive nature of the event. I won't pretend to understand the intricacies, but journalière appears to be the favoured word.

More on the differences: https://french.stackexchange.com/questions/34168/quotidiennement-ou-journalier#34169

Intéressante source @Zeitsperre !
Donc la température serait journalière, parce qu'on précise ici le pas de temps d'une variable (qui varie).

Et boboy, il faudrait donc changer ça partout pour harmoniser.

ah bon! Je ne connaissais pas cette subtilité. Je pense qu'il faudrait mettre journalière partout alors ( pour précipitation aussi)!

xclim/data/fr.json

RondeauG · 2021-11-18T14:15:20Z

xclim/data/fr.json

  },
  "TN_MIN": {
-    "long_name": "Minimum de la température journalière minimale",
+    "long_name": "Minimum de la température journalière",


I would leave it as it were, since this new name loses the notion that Tmin specifically was used.

@EmilieBresson je te lance dans la mêlée.

@RondeauG C'était pour éviter la répétition qui n'a pas de sens puisque le minimum du minimum c'est le minimum... (même principe avec la moyenne de la moyenne). Si ça ne passe pas au conseil OK.

Mais dans cette version-ci, à part pour le champs "description", il n'y a rien qui distingue TX_MIN (min du max), TG_MIN (min de la moyenne) et TN_MIN (min du min), alors que ce sont trois indicateurs différents ?
Ça peut sembler répétitif, mais je crois que c'est un endroit où on peut se le permettre. Mais en même temps, ce n'est pas critique non plus.

Au contraire, non? On aurait : « Minimum de la température journalière maximale », « Minimum de la température journalière moyenne » et « Minimum de la température journalière ».

@aulemahal Mais c'est justement ici ce qui est voué à être retiré, non?
"Minimum de la température journalière minimale" --> "Minimum de la température journalière"

Oui, mais le "minimal" ne serait retiré que pour tn_min puisque c'est le seul endroit où il est redondant? tx_min et tg_min ne sont pas touchés.

Ouais... J'ai peur que ça puisse quand même porter à confusion, mais OK.

En fait est-ce que :

Suggested change

"long_name": "Minimum de la température journalière",

"long_name": "Minimum de la température",

serait encore moins confus? Tsé, le "journalier" n'a plus rien à voir à ce stade.

Mauvaise idée à mon avis. Parce que ça pourrait être de la température horaire initialement et tu pourrais avoir des résultats différents.
Faut discuter de ça avec un plus gros échantillon d'utilisateurs...

RondeauG · 2021-11-18T14:16:14Z

xclim/data/fr.json

-    "title": "Minimum de la température minimale",
-    "comment": "",
-    "abstract": "Minimum de la température journalière minimale."
+    "title": "Température journalière minimale",


Same here. "Minimum de la température journalière minimale" describes TN_min better, I think.

RondeauG · 2021-11-18T14:17:55Z

xclim/data/fr.json

-    "comment": "",
-    "abstract": "Maximum de la température journalière maximale."
+    "title": "Température journalière maximale",
+    "abstract": "Température journalière maximale."


Same as above

xclim/data/fr.json

Zeitsperre · 2021-11-18T15:35:58Z

@Ouranosinc/xclim-core I wanted to make this clear that we can take some time with this PR (not too much; I would like to get this into v0.32) and also clarify that these changes arose from another project that currently patches most of these problems, so there's no rush related to a project.

The changes here don't have to be extensive; As this is a first pass at fixing many of these inconsistencies, this PR is to get the ball rolling. Please feel free to commit directly to the branch if there are any clear issues. Your comments are appreciated!

EmilieBresson · 2021-11-18T15:46:24Z

Ça serait bien de faire une rencontre (en janvier, pas possible avant) avec vous plus Dominique Paquin pour discuter des points qui ne tiennent pas juste de la grammaire (en dessous, au-dessous) ou les fautes de frappes (dessus/dessous). Les points du genre de la Moyenne de la température moyenne.
Bon pour vous ?

Co-authored-by: RondeauG <[email protected]> Co-authored-by: juliettelavoie <[email protected]>

aulemahal

Quelques suggestions et quelques commentaires.

xclim/data/fr.json

aulemahal · 2021-11-18T19:10:20Z

xclim/data/fr.json

+    "long_name": "Cycles de gel-dégel",
+    "description": "Nombre {freq:m} de jours avec un gel-dégel quotidien : Tmax > {thresh_tasmax} et Tmin <= {thresh_tasmin}.",


Je trouve que le "quotidien" est superflu si on parle déjà de "jours". Mais je trouve qu'il manque justement cette information dans le long_name...
Est-ce que "Cycles de gel-dégel diurne" serait approprié?

xclim/data/fr.json

aulemahal · 2021-11-18T19:19:10Z

La plateforme de l'ONU est pratique pour ce genre de traductions : https://unterm.un.org/unterm/portal/welcome

Co-authored-by: Pascal Bourgault <[email protected]>

RondeauG

All previous comments have been resolved.

Zeitsperre · 2021-11-25T18:21:32Z

Thanks, @RondeauG! I'll open another issue to deal with the trickier comments before merging this.

Zeitsperre · 2021-11-25T22:12:37Z

This PR is complete. It just requires #935 to go in before merging. Thanks for all the great comments!

Zeitsperre added 2 commits November 17, 2021 16:29

Rephrasing of many awkward or erroneous French translations

eb6949a

remove empty comments

c3a9ecd

Zeitsperre added the invalid This doesn't seem right label Nov 17, 2021

Zeitsperre added this to the v0.32 milestone Nov 17, 2021

Zeitsperre requested a review from a team November 17, 2021 21:50

Zeitsperre self-assigned this Nov 17, 2021

Zeitsperre changed the title ~~Fench indicator metadata cleanup~~ French indicator metadata cleanup Nov 17, 2021

Zeitsperre added 2 commits November 17, 2021 17:03

adjust translation test expectations

8136afe

blacken

a5b79f4

juliettelavoie approved these changes Nov 17, 2021

View reviewed changes

RondeauG requested changes Nov 18, 2021

View reviewed changes

Merge branch 'master' into corrections_francaises

9cf077d

Apply suggestions from code review

e52a9b3

Co-authored-by: RondeauG <[email protected]> Co-authored-by: juliettelavoie <[email protected]>

aulemahal reviewed Nov 18, 2021

View reviewed changes

Zeitsperre and others added 4 commits November 19, 2021 16:41

Merge branch 'master' into corrections_francaises

2a13992

Apply suggestions from code review

32385bf

Co-authored-by: Pascal Bourgault <[email protected]>

suggested corrections

df4e815

update HISTORY.rst

d71a23e

Zeitsperre added the standards / conventions Suggestions on ways forward label Nov 23, 2021

huard requested a review from RondeauG November 25, 2021 16:04

RondeauG approved these changes Nov 25, 2021

View reviewed changes

Zeitsperre mentioned this pull request Nov 25, 2021

More in-depth French Indicators metadata adjustments #936

Closed

Bump version: 0.31.2-beta → 0.31.3-beta

a35fd98

Merge branch 'master' into corrections_francaises

567cb7c

huard merged commit 5e499a6 into master Nov 26, 2021

huard deleted the corrections_francaises branch November 26, 2021 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

French indicator metadata cleanup #930

French indicator metadata cleanup #930

Zeitsperre commented Nov 17, 2021 •

edited

Loading

coveralls commented Nov 17, 2021 •

edited

Loading

juliettelavoie Nov 17, 2021

Zeitsperre Nov 18, 2021

aulemahal Nov 18, 2021

juliettelavoie Nov 18, 2021

RondeauG Nov 18, 2021

aulemahal Nov 18, 2021

EmilieBresson Nov 18, 2021

RondeauG Nov 18, 2021

aulemahal Nov 18, 2021

RondeauG Nov 18, 2021 •

edited

Loading

aulemahal Nov 18, 2021

RondeauG Nov 18, 2021

aulemahal Nov 18, 2021

EmilieBresson Nov 18, 2021

RondeauG Nov 18, 2021

RondeauG Nov 18, 2021

Zeitsperre commented Nov 18, 2021

EmilieBresson commented Nov 18, 2021

aulemahal left a comment

aulemahal Nov 18, 2021

aulemahal commented Nov 18, 2021

RondeauG left a comment

Zeitsperre commented Nov 25, 2021

Zeitsperre commented Nov 25, 2021

	"long_name": "Minimum de la température journalière",
	"long_name": "Minimum de la température",

		"long_name": "Cycles de gel-dégel",
		"description": "Nombre {freq:m} de jours avec un gel-dégel quotidien : Tmax > {thresh_tasmax} et Tmin <= {thresh_tasmin}.",

French indicator metadata cleanup #930

French indicator metadata cleanup #930

Conversation

Zeitsperre commented Nov 17, 2021 • edited Loading

Pull Request Checklist:

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

Other information:

coveralls commented Nov 17, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1505909016

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RondeauG Nov 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zeitsperre commented Nov 18, 2021

EmilieBresson commented Nov 18, 2021

aulemahal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aulemahal commented Nov 18, 2021

RondeauG left a comment

Choose a reason for hiding this comment

Zeitsperre commented Nov 25, 2021

Zeitsperre commented Nov 25, 2021

Zeitsperre commented Nov 17, 2021 •

edited

Loading

coveralls commented Nov 17, 2021 •

edited

Loading

RondeauG Nov 18, 2021 •

edited

Loading