Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New App Shortcut]: Three Now (NZ) #31

Closed
1 task done
moh-Brent opened this issue Feb 2, 2023 · 4 comments
Closed
1 task done

[New App Shortcut]: Three Now (NZ) #31

moh-Brent opened this issue Feb 2, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request New App Shortcut Request for a new Firemote app shortcut

Comments

@moh-Brent
Copy link

App Name

Three Now (NZ)

Can this app be freely downloaded through official means?

  • Yes

Optional Comments

    "threenow": {
      "button": "Three Now",
      "friendlyName": "Three Now (NZ)",
      "appName": "com.mediaworks.android.tv",
      "className": "threenowButton",
      "androidName": "com.mediaworks.android.tv",
      "adbLaunchCommand": "adb shell am start -n com.mediaworks.android.tv/nz.co.mediaworks.vod.ui.splash.TVSplashActivity" },

          .threenowButton {
            font-size: calc(var(--sz) * 1rem);
            color: #fff;
            font-weight: bold;
            background: #ff004f;
          }
          .threenowButton:active, .threenowButton.appActive {
            color: #fff;
            box-shadow: 0 0 calc(var(--sz) * 0.857rem) calc(var(--sz) * 0.142rem) rgb(255 255 255 / 20%);
            text-shadow: 0 0 calc(var(--sz) * 0.2857rem) black;
          }

@moh-Brent moh-Brent added enhancement New feature or request New App Shortcut Request for a new Firemote app shortcut labels Feb 2, 2023
PRProd added a commit that referenced this issue Feb 4, 2023
Added two new app shortcuts:
 - YouTube Kids #30
 - Three Now #31

This will be a release candidate for two reasons.
- The US version of YouTube Kids had a different App name and ADB
launch command than what was published in the request.  I'll need to
know from the requester https://github.com/moh-Brent if what was sent is
actually accurate in NZ, so I should make an additional entry.
- I cannot test Three now in the US, so I'll need confirmation from the
requester https://github.com/moh-Brent
@PRProd
Copy link
Owner

PRProd commented Feb 4, 2023

@moh-Brent - Please download and test Pre-Release Version 1.10.4 to see if this app shortcut works for you. That app is not available in my region, so I am unable to confirm.

PRProd added a commit that referenced this issue Feb 7, 2023
- #30 Created an alternative version for the YouTube Kids shortcut app
button which should work on non-fire android OS devices.  Cannot test
from my end.  Will wait for results from requester.

- #31 Adjusted the launch command after a testing failure message was
received from the requester.  Cannot test from my end.  Will wait for
updated results from requester.

- #33 Added app shortcut.  Unable to test since this app is not
available in my region.  Will wait for test results from requester.
@PRProd
Copy link
Owner

PRProd commented Feb 7, 2023

From @moh-Brent in #30 also can't get the "Three Now" to work on the Mi Box either

@moh-Brent - Sometimes, the security settings on Android apps don't allow for the direct ADB Launch Command to work properly. I'm hoping that is the reason you experienced an issue with the new shortcut. I've made a change and created a pre-release for you to test. Please download pre-release v1,10.4.2 and re-test the Three Now app shortcut and let me know if it works as expected.

Thanks.

@moh-Brent
Copy link
Author

@PRProd magic mate, this worked perfectly :)

PRProd added a commit that referenced this issue Feb 8, 2023
- #29 Added beta support for 1st Gen Fire Cube (untested)
- #30 Added FireTV and Android app launch support for YouTube Kids
(tested ok @moh-Brent)
 - #31 Added Three Now (NZ) app launch support (tested ok @moh-Brent)
 - #33 Added MyCanal app launch support (untested)
 - #34 Added "App Opener" app launch support (tested)
 - #35 Added RaiPlay (IT) app launch support (untested)
@PRProd
Copy link
Owner

PRProd commented Feb 8, 2023

@moh-Brent - Version 1.11.1 has been released and it contains your requested app shortcut addition. Thank you for your testing efforts earlier, and for your patience with the timing of this release.

Thanks for your contribution!

@PRProd PRProd closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New App Shortcut Request for a new Firemote app shortcut
Projects
None yet
Development

No branches or pull requests

2 participants