Cyborgs Delete Vendor Items (Sometimes)

[Cress67]

Exploit Reports

• I confirm this issue is not an exploit. (Required)

BYOND Version

515.1647

Issue Description

Be any type of Cyborg. Try to vend an item from a vendor. Find that it never comes out, despite the number of items in the vendor decreasing. It basically ceases to exist. Try to vend additional items. After around three ceasing to exist, the items now spawn on top of the vendor as expected.

What did you expect to happen?

For vendors to dispense the items you ask them to dispense.

What happened instead?

Items ceased to exist instead of being vended.

Why is this bad/What are the consequences?

It deletes a lot of potentially highly important vendor items, such as various medicines in the Medbay. You can "bait" it by dispensing less useful items until one actually comes out, then dispense the real thing you wanted, but that's annoying as hell and not a real fix.

Steps to reproduce the issue.

Be a borg. Try to vend items from a vendor.

When did the problem start happening?

Around a week or two ago.

Extra information

There's a definite chance that the Cyborg Inventory Refactor (#27788) had some effect on this.

Relevant log output/runtime error

[JackSage]

As another temporary fix, as a Borg Ive found by standing a few tiles away from the vendor then dispensing wait for the item to pop up then you can move up and grab/drag it

[Toastical]

A recent PR caused vendors to not check if a mob is permitted to actually hold items, resulting in them being dispensed into the cyborgs hands. After vending 3 items, your hands will be full and you can safely vend again.