Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from react-keycloak and keycloak-js to some dedicated OIDC js client #132

Closed
Powersource opened this issue Oct 29, 2020 · 3 comments · Fixed by #133
Closed

Switch from react-keycloak and keycloak-js to some dedicated OIDC js client #132

Powersource opened this issue Oct 29, 2020 · 3 comments · Fixed by #133
Labels
Priority: 1 (now)

Comments

@Powersource
Copy link
Member

This should hopefully fix #123 and therefore also help with #130 and possibly also #131 as well as hopefully getting better support for browsers that block 3rd party cookies (safari atm but soon prob more)
This was referenced Oct 29, 2020
Closed
Closed
@Powersource
Copy link
Member Author

@Powersource
Copy link
Member Author

Powersource commented Nov 2, 2020 •
edited
Loading

These are all frontend libraries. Will I have to change anything in the backend or might the keycloak code we have there now maybe just work? It's just grabbing a token and checking that, and the token should be the same whatever oidc client we have in the frontend. Otherwise there seems to be a passport middleware that hasn't been updated in a long time but seems popular-ish https://www.npmjs.com/package/passport-openidconnect

And I think I'm gonna try out the oidc-react linked above, it's the one that seems the most modern (has hooks).

This was referenced Nov 2, 2020
Merged
Closed
@Powersource
Copy link
Member Author

Improved #123 and #130 but didn't fix them (see comments in them), might have fixed #131 but we'll have to see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 1 (now)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from react-keycloak to oidc-react ParticipioLabs/realities
1 participant
@Powersource