Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-eject create-react-app #98

Closed
Powersource opened this issue Sep 3, 2020 · 4 comments · Fixed by #134
Closed

Un-eject create-react-app #98

Powersource opened this issue Sep 3, 2020 · 4 comments · Fixed by #134

Comments

@Powersource
Copy link
Member

From talking with @gustavlrsn it sounded like most of the files in at least ui/config and ui/scripts were automatically generated when ejecting from create-react-app. They're pretty complex and they're not updated when we update react/webpack, so it feels like they'll break eventually.

@Powersource Powersource added the ui label Sep 3, 2020
@Powersource
Copy link
Member Author

Erik said if we remove the webpack configs then then @ imports will stop working but we could use https://code.visualstudio.com/docs/languages/jsconfig instead to set the root import location

@Powersource
Copy link
Member Author

@Powersource Powersource changed the title Get rid of old ejected create-react-app files Un-eject create-react-app Nov 3, 2020
@Powersource
Copy link
Member Author

The commit that ejected bf7c423

@Powersource
Copy link
Member Author

Apparently we might need react-scripts@3 to be able to use the absolute imports https://medium.com/hackernoon/absolute-imports-with-create-react-app-4c6cfb66c35d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant